« previous next »
Pages: [1]

Author Topic: Skin change resets fighting style to grabkick  (Read 1469 times)

0 Members and 1 Guest are viewing this topic.

Offline J0HNNY_FAT_C00K

  • Enforcer
  • *
  • Posts: 176
  • Country: it
  • Respect: +2/-25
  • People ask the question... what's a RocknRolla?
    • View Profile
  • MCNR name: J0HNNY_F@T_C0CK
  • Discord name: J0HNNY_R0CK#2558
  • Crew: N/A
Skin change resets fighting style to grabkick
« on: January 06, 2022, 08:34:28 pm »
I had kneehead fight style, when i changed skin to the vago without shirt i had default grabkick fightstyle

I also think a change fightstyle command should be added to switch between the learned fighting styles /fs
Logged
Yes ma'am

Offline Mike

  • Server Owner
  • *
  • Posts: 3682
  • Country: gb
  • Respect: +413/-71
  • Gender: Male
    • View Profile
  • MCNR name: Mike
  • Discord name: mp2
Re: Skin change resets fighting style to grabkick
« Reply #1 on: January 06, 2022, 08:47:17 pm »
/fightstyle already exists.

As for the fight style reset, are you sure this wasn't when 1.14.3 was released? All /settings had to be reset.
Logged
View trailers here.

Offline howl

  • Original Gangster
  • *
  • Posts: 948
  • Country: ua
  • Respect: +110/-183
  • Gender: Male
    • View Profile
Re: Skin change resets fighting style to grabkick
« Reply #2 on: January 06, 2022, 09:18:01 pm »
Quote from: Mike on January 06, 2022, 08:47:17 pm
/fightstyle already exists.

As for the fight style reset, are you sure this wasn't when 1.14.3 was released? All /settings had to be reset.

But why?
Logged

Offline Mike

  • Server Owner
  • *
  • Posts: 3682
  • Country: gb
  • Respect: +413/-71
  • Gender: Male
    • View Profile
  • MCNR name: Mike
  • Discord name: mp2
Re: Skin change resets fighting style to grabkick
« Reply #3 on: January 07, 2022, 08:22:58 am »
Why what?

By the way settings were reset again last night.
Logged
View trailers here.

Offline howl

  • Original Gangster
  • *
  • Posts: 948
  • Country: ua
  • Respect: +110/-183
  • Gender: Male
    • View Profile
Re: Skin change resets fighting style to grabkick
« Reply #4 on: January 07, 2022, 10:10:43 am »
Quote from: Mike on January 07, 2022, 08:22:58 am
Why what?

By the way settings were reset again last night.

What's the point of resetting our settings, it doesn't make any sense nor there's even a need for it
Logged

Offline ChrisAg

  • *
  • Posts: 121
  • Country: gr
  • Respect: +16/-5
  • Gender: Male
  • Everything is computable!
    • View Profile
  • MCNR name: ChrisAg
  • Discord name: xchris.agorx#7596
Re: Skin change resets fighting style to grabkick
« Reply #5 on: January 07, 2022, 10:43:33 am »
Quote from: howl on January 07, 2022, 10:10:43 am
What's the point of resetting our settings, it doesn't make any sense nor there's even a need for it

Check the current changelog you will see why they had to reset.
https://mikescnr.com/forum/index.php/topic,10079.msg48101.html

Quote
PLAYER SETTINGS WIPE
The backend system for saving players /settings has been rewritten for efficiency and code maintainability.
Unfortunately all players' existing settings have been reset to defaults.
Logged

Offline BorisminMilk

  • Enforcer
  • *
  • Posts: 247
  • Country: ph
  • Respect: +21/-8
  • Gender: Male
    • View Profile
Re: Skin change resets fighting style to grabkick
« Reply #6 on: January 08, 2022, 01:40:53 am »
Invalid issue, Moved to invalid bugs. settings has been wiped out for efficiency and code maintainability. check the changelog to see more.
https://mikescnr.com/forum/index.php/topic,10079.msg48101.html
Logged

Offline Mike

  • Server Owner
  • *
  • Posts: 3682
  • Country: gb
  • Respect: +413/-71
  • Gender: Male
    • View Profile
  • MCNR name: Mike
  • Discord name: mp2
Re: Skin change resets fighting style to grabkick
« Reply #7 on: January 08, 2022, 04:19:21 pm »
Quote from: howl on January 07, 2022, 10:10:43 am
What's the point of resetting our settings, it doesn't make any sense nor there's even a need for it
@howl Do you think I do things for the fun of it?

The settings used to be saved in a stupid way, with a pipe-delimited string, e.g.
Code: [Select]
1|2|3|4|5
This was hard to maintain, and practically possible to ever remove or reorder settings. They are now saved separately in the database so reordering and deleting settings is now possible.
It's one of the many changes I have to make in the back-end of MCNR that nobody ever sees, and usually the effects are unnoticable, however sometimes I have to reset things.

I could have written code to convert the old settings to the new format, however the chance of there being bugs in such code mean it's not worth it. It's not like people have lost stats/progress, only a couple of settings.....
Logged
View trailers here.

Offline howl

  • Original Gangster
  • *
  • Posts: 948
  • Country: ua
  • Respect: +110/-183
  • Gender: Male
    • View Profile
Re: Skin change resets fighting style to grabkick
« Reply #8 on: January 09, 2022, 04:50:38 am »
Quote from: Mike on January 08, 2022, 04:19:21 pm
@howl Do you think I do things for the fun of it?

The settings used to be saved in a stupid way, with a pipe-delimited string, e.g.
Code: [Select]
1|2|3|4|5
This was hard to maintain, and practically possible to ever remove or reorder settings. They are now saved separately in the database so reordering and deleting settings is now possible.
It's one of the many changes I have to make in the back-end of MCNR that nobody ever sees, and usually the effects are unnoticable, however sometimes I have to reset things.

I could have written code to convert the old settings to the new format, however the chance of there being bugs in such code mean it's not worth it. It's not like people have lost stats/progress, only a couple of settings.....

I guess you have a point, sorry for misunderstanding you
Logged
Pages: [1]
« previous next »