Mike's Cops and Robbers

Community => Bug Reports => Invalid Bugs => Topic started by: J0HNNY_FAT_C00K on January 06, 2022, 08:34:28 pm

Title: Skin change resets fighting style to grabkick
Post by: J0HNNY_FAT_C00K on January 06, 2022, 08:34:28 pm
I had kneehead fight style, when i changed skin to the vago without shirt i had default grabkick fightstyle

I also think a change fightstyle command should be added to switch between the learned fighting styles /fs
Title: Re: Skin change resets fighting style to grabkick
Post by: Mike on January 06, 2022, 08:47:17 pm
/fightstyle already exists.

As for the fight style reset, are you sure this wasn't when 1.14.3 was released? All /settings had to be reset.
Title: Re: Skin change resets fighting style to grabkick
Post by: howl on January 06, 2022, 09:18:01 pm
/fightstyle already exists.

As for the fight style reset, are you sure this wasn't when 1.14.3 was released? All /settings had to be reset.

But why?
Title: Re: Skin change resets fighting style to grabkick
Post by: Mike on January 07, 2022, 08:22:58 am
Why what?

By the way settings were reset again last night.
Title: Re: Skin change resets fighting style to grabkick
Post by: howl on January 07, 2022, 10:10:43 am
Why what?

By the way settings were reset again last night.

What's the point of resetting our settings, it doesn't make any sense nor there's even a need for it
Title: Re: Skin change resets fighting style to grabkick
Post by: ChrisAg on January 07, 2022, 10:43:33 am
What's the point of resetting our settings, it doesn't make any sense nor there's even a need for it

Check the current changelog you will see why they had to reset.
https://mikescnr.com/forum/index.php/topic,10079.msg48101.html

Quote
PLAYER SETTINGS WIPE
The backend system for saving players /settings has been rewritten for efficiency and code maintainability.
Unfortunately all players' existing settings have been reset to defaults.
Title: Re: Skin change resets fighting style to grabkick
Post by: BorisminMilk on January 08, 2022, 01:40:53 am
Invalid issue, Moved to invalid bugs. settings has been wiped out for efficiency and code maintainability. check the changelog to see more.
https://mikescnr.com/forum/index.php/topic,10079.msg48101.html
Title: Re: Skin change resets fighting style to grabkick
Post by: Mike on January 08, 2022, 04:19:21 pm
What's the point of resetting our settings, it doesn't make any sense nor there's even a need for it
@howl Do you think I do things for the fun of it?

The settings used to be saved in a stupid way, with a pipe-delimited string, e.g.
Code: [Select]
1|2|3|4|5
This was hard to maintain, and practically possible to ever remove or reorder settings. They are now saved separately in the database so reordering and deleting settings is now possible.
It's one of the many changes I have to make in the back-end of MCNR that nobody ever sees, and usually the effects are unnoticable, however sometimes I have to reset things.

I could have written code to convert the old settings to the new format, however the chance of there being bugs in such code mean it's not worth it. It's not like people have lost stats/progress, only a couple of settings.....
Title: Re: Skin change resets fighting style to grabkick
Post by: howl on January 09, 2022, 04:50:38 am
@howl Do you think I do things for the fun of it?

The settings used to be saved in a stupid way, with a pipe-delimited string, e.g.
Code: [Select]
1|2|3|4|5
This was hard to maintain, and practically possible to ever remove or reorder settings. They are now saved separately in the database so reordering and deleting settings is now possible.
It's one of the many changes I have to make in the back-end of MCNR that nobody ever sees, and usually the effects are unnoticable, however sometimes I have to reset things.

I could have written code to convert the old settings to the new format, however the chance of there being bugs in such code mean it's not worth it. It's not like people have lost stats/progress, only a couple of settings.....

I guess you have a point, sorry for misunderstanding you